Skip to content
This repository has been archived by the owner on Sep 30, 2018. It is now read-only.

Commit

Permalink
changed: minimize URL.h header pollution
Browse files Browse the repository at this point in the history
  • Loading branch information
spiff committed Jul 24, 2012
1 parent 6dd20c0 commit 52e4d3b
Show file tree
Hide file tree
Showing 57 changed files with 72 additions and 18 deletions.
1 change: 1 addition & 0 deletions xbmc/GUIInfoManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
#include "utils/StringUtils.h"
#include "utils/MathUtils.h"
#include "utils/SeekHandler.h"
#include "URL.h"

// stuff for current song
#include "music/MusicInfoLoader.h"
Expand Down
1 change: 0 additions & 1 deletion xbmc/GUIPassword.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
#include "settings/GUIDialogLockSettings.h"
#include "settings/GUIDialogProfileSettings.h"
#include "Util.h"
#include "URL.h"
#include "settings/Settings.h"
#include "settings/GUISettings.h"
#include "guilib/GUIWindowManager.h"
Expand Down
1 change: 1 addition & 0 deletions xbmc/TextureCache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "settings/AdvancedSettings.h"
#include "utils/log.h"
#include "utils/URIUtils.h"
#include "URL.h"

using namespace XFILE;

Expand Down
1 change: 1 addition & 0 deletions xbmc/Util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
#include "cores/dvdplayer/DVDSubtitles/DVDSubtitleTagSami.h"
#include "cores/dvdplayer/DVDSubtitles/DVDSubtitleStream.h"
#include "windowing/WindowingFactory.h"
#include "URL.h"
#ifdef HAVE_LIBCAP
#include <sys/capability.h>
#endif
Expand Down
1 change: 1 addition & 0 deletions xbmc/addons/Addon.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#endif
#include "utils/log.h"
#include "utils/URIUtils.h"
#include "URL.h"
#include <vector>
#include <string.h>
#include <ostream>
Expand Down
1 change: 1 addition & 0 deletions xbmc/addons/AddonInstaller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include "utils/StringUtils.h"
#include "dialogs/GUIDialogKaiToast.h"
#include "dialogs/GUIDialogProgress.h"
#include "URL.h"

using namespace std;
using namespace XFILE;
Expand Down
1 change: 1 addition & 0 deletions xbmc/addons/GUIDialogAddonSettings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
#include "GUIWindowAddonBrowser.h"
#include "utils/log.h"
#include "Util.h"
#include "URL.h"

using namespace std;
using namespace ADDON;
Expand Down
1 change: 1 addition & 0 deletions xbmc/addons/Repository.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "dialogs/GUIDialogYesNo.h"
#include "dialogs/GUIDialogKaiToast.h"
#include "TextureDatabase.h"
#include "URL.h"

using namespace XFILE;
using namespace ADDON;
Expand Down
1 change: 0 additions & 1 deletion xbmc/addons/Repository.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "Addon.h"
#include "AddonManager.h"
#include "XBDateTime.h"
#include "URL.h"
#include "utils/Job.h"
#include "threads/CriticalSection.h"
#include "threads/SingleLock.h"
Expand Down
1 change: 1 addition & 0 deletions xbmc/addons/Scraper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include "music/Album.h"
#include "music/Artist.h"
#include "Util.h"
#include "URL.h"

#include <sstream>

Expand Down
1 change: 1 addition & 0 deletions xbmc/cores/AudioEngine/Utils/AEWAVLoader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include "utils/EndianSwap.h"
#include "filesystem/FileFactory.h"
#include "filesystem/IFile.h"
#include "URL.h"
#include <samplerate.h>

#include "AEConvert.h"
Expand Down
1 change: 1 addition & 0 deletions xbmc/cores/DllLoader/DllLoaderContainer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "utils/URIUtils.h"
#include "utils/StringUtils.h"
#include "utils/log.h"
#include "URL.h"

#define ENV_PARTIAL_PATH "special://xbmcbin/system/;" \
"special://xbmcbin/system/players/mplayer/;" \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "filesystem/File.h"
#include "filesystem/Directory.h"
#include "DllLibbluray.h"
#include "URL.h"

#define LIBBLURAY_BYTESEEK 0

Expand Down
1 change: 1 addition & 0 deletions xbmc/cores/dvdplayer/Edl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "utils/log.h"
#include "utils/XBMCTinyXML.h"
#include "PlatformDefs.h"
#include "URL.h"

extern "C"
{
Expand Down
1 change: 0 additions & 1 deletion xbmc/cores/dvdplayer/Edl.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include <vector>
#include <stdint.h>
#include "utils/StdString.h"
#include "URL.h"

class CEdl
{
Expand Down
1 change: 1 addition & 0 deletions xbmc/cores/paplayer/DVDPlayerCodec.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "cores/dvdplayer/DVDCodecs/DVDFactoryCodec.h"
#include "utils/log.h"
#include "settings/GUISettings.h"
#include "URL.h"

#include "AudioDecoder.h"

Expand Down
1 change: 1 addition & 0 deletions xbmc/cores/paplayer/TimidityCodec.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
*/

#include "TimidityCodec.h"
#include "URL.h"
#include "../DllLoader/LibraryLoader.h"
#include "../DllLoader/SoLoader.h"
#include "../DllLoader/DllLoader.h"
Expand Down
1 change: 1 addition & 0 deletions xbmc/dialogs/GUIDialogContextMenu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include "guilib/LocalizeStrings.h"
#include "TextureCache.h"
#include "video/windows/GUIWindowVideoBase.h"
#include "URL.h"

#ifdef _WIN32
#include "WIN32Util.h"
Expand Down
1 change: 1 addition & 0 deletions xbmc/dialogs/GUIDialogFileBrowser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include "settings/GUISettings.h"
#include "guilib/LocalizeStrings.h"
#include "utils/log.h"
#include "URL.h"

using namespace XFILE;

Expand Down
1 change: 1 addition & 0 deletions xbmc/dialogs/GUIDialogMediaSource.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include "settings/GUISettings.h"
#include "guilib/LocalizeStrings.h"
#include "PasswordManager.h"
#include "URL.h"

using namespace std;
using namespace XFILE;
Expand Down
1 change: 1 addition & 0 deletions xbmc/filesystem/AddonsDirectory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "guilib/TextureManager.h"
#include "File.h"
#include "utils/URIUtils.h"
#include "URL.h"

using namespace ADDON;

Expand Down
2 changes: 1 addition & 1 deletion xbmc/filesystem/HTSPDirectory.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
#include "threads/Thread.h"
#include "threads/CriticalSection.h"
#include "threads/Event.h"
#include "URL.h"
#include "HTSPSession.h"
#include "boost/shared_ptr.hpp"

class CURL;
class CFileItem; typedef boost::shared_ptr<CFileItem> CFileItemPtr;

namespace HTSP
Expand Down
11 changes: 11 additions & 0 deletions xbmc/filesystem/IFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
*/

#include "IFile.h"
#include "URL.h"
#include <cstring>
#include <errno.h>

Expand Down Expand Up @@ -88,3 +89,13 @@ bool IFile::ReadString(char *szLine, int iLineLength)
}
return true;
}

CRedirectException::CRedirectException() :
m_pNewFileImp(NULL), m_pNewUrl(NULL)
{
}

CRedirectException::CRedirectException(IFile *pNewFileImp, CURL *pNewUrl) :
m_pNewFileImp(pNewFileImp), m_pNewUrl(pNewUrl)
{
}
13 changes: 6 additions & 7 deletions xbmc/filesystem/IFile.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@
#include "PlatformDefs.h" // for __stat64
#endif

#include "URL.h"

#include <stdio.h>
#include <stdint.h>
#include <sys/stat.h>

#include "utils/StdString.h"

class CURL;

namespace XFILE
{

Expand Down Expand Up @@ -107,12 +109,9 @@ class CRedirectException
IFile *m_pNewFileImp;
CURL *m_pNewUrl;

CRedirectException() : m_pNewFileImp(NULL), m_pNewUrl(NULL) { }
CRedirectException();

CRedirectException(IFile *pNewFileImp, CURL *pNewUrl=NULL)
: m_pNewFileImp(pNewFileImp)
, m_pNewUrl(pNewUrl)
{ }
CRedirectException(IFile *pNewFileImp, CURL *pNewUrl=NULL);
};

}
Expand Down
1 change: 1 addition & 0 deletions xbmc/filesystem/PipeFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "threads/SingleLock.h"
#include "PipesManager.h"
#include "utils/StringUtils.h"
#include "URL.h"

using namespace XFILE;

Expand Down
1 change: 1 addition & 0 deletions xbmc/filesystem/PluginDirectory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include "utils/log.h"
#include "utils/TimeUtils.h"
#include "ApplicationMessenger.h"
#include "URL.h"

using namespace XFILE;
using namespace std;
Expand Down
3 changes: 2 additions & 1 deletion xbmc/filesystem/SAPFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "SAPFile.h"
#include "SAPDirectory.h"
#include "threads/SingleLock.h"
#include "URL.h"

#include <sys/stat.h>
#include <vector>
Expand Down Expand Up @@ -175,4 +176,4 @@ int CSAPFile::IoControl(EIoControl request, void* param)
return 1;

return -1;
}
}
1 change: 1 addition & 0 deletions xbmc/filesystem/SFTPFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "utils/TimeUtils.h"
#include "utils/Variant.h"
#include "Util.h"
#include "URL.h"
#include <fcntl.h>
#include <sstream>

Expand Down
3 changes: 2 additions & 1 deletion xbmc/filesystem/SFTPFile.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include "system.h"
#ifdef HAS_FILESYSTEM_SFTP
#include "IFile.h"
#include "URL.h"
#include "FileItem.h"
#include "threads/CriticalSection.h"

Expand All @@ -34,6 +33,8 @@
#include <map>
#include <boost/shared_ptr.hpp>

class CURL;

#if LIBSSH_VERSION_INT < SSH_VERSION_INT(0,3,2)
#define ssh_session SSH_SESSION
#endif
Expand Down
1 change: 1 addition & 0 deletions xbmc/filesystem/SlingboxFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "settings/Settings.h"
#include "utils/log.h"
#include "utils/XMLUtils.h"
#include "URL.h"

using namespace XFILE;
using namespace std;
Expand Down
1 change: 1 addition & 0 deletions xbmc/filesystem/UPnPFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "FileFactory.h"
#include "FileItem.h"
#include "utils/log.h"
#include "URL.h"

using namespace XFILE;

Expand Down
1 change: 1 addition & 0 deletions xbmc/guilib/GUIFontManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "utils/URIUtils.h"
#include "utils/StringUtils.h"
#include "windowing/WindowingFactory.h"
#include "URL.h"

using namespace std;

Expand Down
1 change: 1 addition & 0 deletions xbmc/guilib/TextureManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#endif
#include "filesystem/File.h"
#include "filesystem/Directory.h"
#include "URL.h"
#include <assert.h>

using namespace std;
Expand Down
1 change: 1 addition & 0 deletions xbmc/interfaces/Builtins.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
#include "utils/StringUtils.h"
#include "utils/URIUtils.h"
#include "Util.h"
#include "URL.h"

#include "filesystem/PluginDirectory.h"
#ifdef HAS_FILESYSTEM_RAR
Expand Down
1 change: 1 addition & 0 deletions xbmc/interfaces/http-api/XBMChttp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#include "utils/log.h"
#include "TextureCache.h"
#include "ThumbLoader.h"
#include "URL.h"

#ifdef _WIN32
extern "C" FILE *fopen_utf8(const char *_Filename, const char *_Mode);
Expand Down
1 change: 1 addition & 0 deletions xbmc/interfaces/python/xbmcmodule/xbmcmodule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
#include "utils/log.h"
#include "pyrendercapture.h"
#include "monitor.h"
#include "URL.h"

// include for constants
#include "pyutil.h"
Expand Down
1 change: 1 addition & 0 deletions xbmc/music/MusicDatabase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
#include "interfaces/AnnouncementManager.h"
#include "dbwrappers/dataset.h"
#include "utils/XMLUtils.h"
#include "URL.h"

using namespace std;
using namespace AUTOPTR;
Expand Down
1 change: 0 additions & 1 deletion xbmc/music/infoscanner/MusicInfoScraper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
*/

#include "MusicInfoScraper.h"
#include "URL.h"
#include "utils/CharsetConverter.h"
#include "utils/log.h"

Expand Down
1 change: 1 addition & 0 deletions xbmc/music/windows/GUIWindowMusicBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
#include "video/VideoInfoTag.h"
#include "utils/StringUtils.h"
#include "ThumbLoader.h"
#include "URL.h"

using namespace std;
using namespace XFILE;
Expand Down
1 change: 1 addition & 0 deletions xbmc/music/windows/GUIWindowMusicNav.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
#include "utils/StringUtils.h"
#include "TextureCache.h"
#include "Util.h"
#include "URL.h"

using namespace std;
using namespace XFILE;
Expand Down
1 change: 1 addition & 0 deletions xbmc/network/AirPlayServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "utils/md5.h"
#include "utils/Variant.h"
#include "guilib/GUIWindowManager.h"
#include "URL.h"

#ifdef TARGET_WINDOWS
#define close closesocket
Expand Down
1 change: 1 addition & 0 deletions xbmc/network/AirTunesServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
#include "utils/Variant.h"
#include "settings/AdvancedSettings.h"
#include "utils/EndianSwap.h"
#include "URL.h"

#include <map>
#include <string>
Expand Down
Loading

0 comments on commit 52e4d3b

Please sign in to comment.