[plugin.video.imdb.trailers] v2.1.8

[Gujal00]

Description

This addon allows to watch movie trailers available on IMDb Website

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

[TravisBuddy]

Travis tests were successful

Hey @Gujal00,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[Rechi]

@Gujal00 this add-on isn't Python 3 compatible, but all add-ons in Leia branch and higher have to be Python 3 compatible (see https://kodi.tv/article/attention-addon-developers-migration-python-3).

[Gujal00]

@Gujal00 this add-on isn't Python 3 compatible, but all add-ons in Leia branch and higher have to be Python 3 compatible (see https://kodi.tv/article/attention-addon-developers-migration-python-3).

I dont understand, I did all the changes for the addon to work on KodiSetup-20190508-13148516-feature_python3-x64.exe and works fine in it.
Yes there is a dependency addon script.common.plugin.cache which is not py3 compatible. I am not the maintainer of that script addon, so I did a monkey patch on that script to make it respond (just loopback no actual functionality) on the py3 kodi version above so that my addon could be tested on py3
The other dependency script.module.beautifulsoup4 is already py3 ready and I installed it manually from migration repo.
I do not know what I can do now, as the addon itself is py3 compatible and works but the dependency from the official repo is not py3 compatible

[TravisBuddy]

Travis tests were successful

Hey @Gujal00,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[Rechi]

An add-on is only python3 compatible if all it's dependencies and itself is python3 compatible.
Do you want that every user of your add-on first fixes script.common.plugin.cache to be Python 3 compatible before your add-on can be used?
Also do not expect that script.common.plugin.cache will ever by Python 3 compatible, unless your or someone else who uses it fixes it. It currently has no maintainer.

[Gujal00]

Also do not expect that script.common.plugin.cache will ever by Python 3 compatible, unless your or someone else who uses it fixes it. It currently has no maintainer.

Okay, please mark this PR as waiting for Developer. I will see if I can make script.common.plugin.cache py3 ready

[TravisBuddy]

Travis tests were successful

Hey @Gujal00,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[Gujal00]

I have recoded the addon to use requests.cache instead of script.common.plugin.cache.
Now the addon and dependencies are PY3 compatible and ready for your review.

[TravisBuddy]

Travis tests were successful

Hey @Gujal00,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @Gujal00,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

add-on is now Python 3 compatible