Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.youtube] 6.8.4 #3106

Merged
merged 1 commit into from
Sep 9, 2020
Merged

[plugin.video.youtube] 6.8.4 #3106

merged 1 commit into from
Sep 9, 2020

Conversation

anxdpanic
Copy link
Member

Description

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@TravisBuddy
Copy link

Travis tests have failed

Hey @anxdpanic,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here
INFO: Checking add-on plugin.video.youtube
INFO: Created by anxdpanic, bromix
INFO: Addon id matches folder name
ERROR: plugin.video.youtube addon already exists with a lower or equal version: 6.8.3+matrix.1 in matrix branch and the addon has non forward abi compatible dependencies. Users migrating to kodi version matrix won't be able to receive the addon update.
INFO: plugin.video.youtube addon also exists in isengard branch but with update compatible version: 6.8.3
INFO: Valid XML file found
WARN: https://ytaddon.page.link/forum redirects to https://forum.kodi.tv/showthread.php?tid=356934
INFO: Optional dependency script.module.inputstreamhelper is not available in current repository
INFO: Reverse dependencies: metadata.filmweb.pl, metadata.themoviedb.org, metadata.themoviedb.org.python, plugin.audio.lastfmtube, plugin.audio.mikemassetv, plugin.video.101barz, plugin.video.ad6, plugin.video.attactv, plugin.video.bobross, plugin.video.comicbook, plugin.video.crossroads, plugin.video.disclosetv, plugin.video.doomcomhr, plugin.video.dumpert, plugin.video.eevblogtv, plugin.video.eye, plugin.video.filmrisetv, plugin.video.filmsforaction, plugin.video.fitnessblenderv2, plugin.video.gamekings, plugin.video.hak5, plugin.video.hardstyletv, plugin.video.haystacktv, plugin.video.hsn, plugin.video.infographics, plugin.video.infowars, plugin.video.jpcandioti.5rtv, plugin.video.koditube, plugin.video.kurzgesagt, plugin.video.metalvideo, plugin.video.netzkino_de, plugin.video.npr, plugin.video.popcorntv, plugin.video.retrospect, plugin.video.rocketbeans, plugin.video.rt, plugin.video.s04tv, plugin.video.skynews, plugin.video.spurs-tv, plugin.video.steamcommunity, plugin.video.theverge, plugin.video.tmos, plugin.video.trekyards, plugin.video.vercelliwebtv, plugin.video.ytchannels, screensaver.system47, script.module.youtube_channels, script.tubecast (48)
INFO: Reverse dependencies (in lower branches): metadata.filmaffinity.com, metadata.themoviedb.org, plugin.video.amaproracing, plugin.video.break_com, plugin.video.classiccinema, plugin.video.docu, plugin.video.earthtouch, plugin.video.gamegurumania, plugin.video.gronkh.de, plugin.video.guardian, plugin.video.heritagechannel, plugin.video.hollywoodreporter, plugin.video.khanacademy, plugin.video.latelelibre_fr, plugin.video.metalvideo, plugin.video.nlhardwareinfo, plugin.video.npr, plugin.video.powerunlimited, plugin.video.radbox, plugin.video.reddit_tv, plugin.video.science.friday, plugin.video.sgtv, plugin.video.spurs-tv, plugin.video.tmos, plugin.video.udacity, plugin.video.watchmojo (26)
INFO: Image icon exists
INFO: icon dimensions are fine 256x256
INFO: Image fanart exists
INFO: fanart dimensions are fine 1280x720
INFO: fanart file size is fine 42KB
INFO: PO files are valid
WARN: Found non whitelisted file ending in filename ./plugin.video.youtube/LICENSES/GPL-2.0-only
ERROR: We found 1 problems and 2 warnings, please check the logfile.

Copy link
Member

@pkscout pkscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@learningit learningit closed this Sep 8, 2020
@learningit learningit reopened this Sep 8, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @anxdpanic,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here
INFO: Checking add-on plugin.video.youtube
INFO: Created by anxdpanic, bromix
INFO: Addon id matches folder name
ERROR: plugin.video.youtube addon already exists with a lower or equal version: 6.8.3+matrix.1 in matrix branch and the addon has non forward abi compatible dependencies. Users migrating to kodi version matrix won't be able to receive the addon update.
INFO: plugin.video.youtube addon also exists in isengard branch but with update compatible version: 6.8.3
INFO: Valid XML file found
WARN: https://ytaddon.page.link/forum redirects to https://forum.kodi.tv/showthread.php?tid=356934
INFO: Optional dependency script.module.inputstreamhelper is not available in current repository
INFO: Reverse dependencies: metadata.filmweb.pl, metadata.themoviedb.org, metadata.themoviedb.org.python, plugin.audio.lastfmtube, plugin.audio.mikemassetv, plugin.video.101barz, plugin.video.ad6, plugin.video.attactv, plugin.video.bobross, plugin.video.comicbook, plugin.video.crossroads, plugin.video.disclosetv, plugin.video.doomcomhr, plugin.video.dumpert, plugin.video.eevblogtv, plugin.video.eye, plugin.video.filmrisetv, plugin.video.filmsforaction, plugin.video.fitnessblenderv2, plugin.video.gamekings, plugin.video.hak5, plugin.video.hardstyletv, plugin.video.haystacktv, plugin.video.hsn, plugin.video.infographics, plugin.video.infowars, plugin.video.jpcandioti.5rtv, plugin.video.koditube, plugin.video.kurzgesagt, plugin.video.metalvideo, plugin.video.netzkino_de, plugin.video.npr, plugin.video.popcorntv, plugin.video.retrospect, plugin.video.rocketbeans, plugin.video.rt, plugin.video.s04tv, plugin.video.skynews, plugin.video.spurs-tv, plugin.video.steamcommunity, plugin.video.theverge, plugin.video.tmos, plugin.video.trekyards, plugin.video.vercelliwebtv, plugin.video.ytchannels, screensaver.system47, script.module.youtube_channels, script.tubecast (48)
INFO: Reverse dependencies (in lower branches): metadata.filmaffinity.com, metadata.themoviedb.org, plugin.video.amaproracing, plugin.video.break_com, plugin.video.classiccinema, plugin.video.docu, plugin.video.earthtouch, plugin.video.gamegurumania, plugin.video.gronkh.de, plugin.video.guardian, plugin.video.heritagechannel, plugin.video.hollywoodreporter, plugin.video.khanacademy, plugin.video.latelelibre_fr, plugin.video.metalvideo, plugin.video.nlhardwareinfo, plugin.video.npr, plugin.video.powerunlimited, plugin.video.radbox, plugin.video.reddit_tv, plugin.video.science.friday, plugin.video.sgtv, plugin.video.spurs-tv, plugin.video.tmos, plugin.video.udacity, plugin.video.watchmojo (26)
INFO: Image icon exists
INFO: icon dimensions are fine 256x256
INFO: Image fanart exists
INFO: fanart dimensions are fine 1280x720
INFO: fanart file size is fine 42KB
INFO: PO files are valid
WARN: Found non whitelisted file ending in filename ./plugin.video.youtube/LICENSES/GPL-2.0-only
ERROR: We found 1 problems and 2 warnings, please check the logfile.

@learningit
Copy link
Member

I'm really not sure why Travis is complaining here. The version looks correct to me, but Travis is complaining about it. It issued just a warning for the matrix version

@anxdpanic
Copy link
Member Author

it will work after ~2 hours, the matrix version has to be propagated to the mirrors first

@TravisBuddy
Copy link

Travis tests were successful

Hey @anxdpanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@basrieter basrieter merged commit cc19e85 into xbmc:isengard Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants