Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[game.controller.*] remove empty requires tag #57

Merged
merged 69 commits into from
Sep 26, 2018
Merged

[game.controller.*] remove empty requires tag #57

merged 69 commits into from
Sep 26, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Sep 26, 2018

Description

remove empty requires tag from game.controller.* add-ons

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@Rechi Rechi requested a review from garbear September 26, 2018 12:23
@TravisBuddy

This comment has been minimized.

@garbear
Copy link
Member

garbear commented Sep 26, 2018

The errors are because 7800 were bumped to v1.0.7 already. Just bump everything to v1.0.8 if you want.

@Rechi
Copy link
Member Author

Rechi commented Sep 26, 2018

Already noticed that, I just fix the two add-ons, instead of changing all version numbers again.

@TravisBuddy
Copy link

Travis tests were successfully

Hey @Rechi,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@garbear
Copy link
Member

garbear commented Sep 26, 2018

ported to master: xbmc/xbmc#14482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants