Add missing SNES controller profile #14481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rechi
reviewed
Sep 26, 2018
| version="1.0.6" | ||
| provider-name="Team Kodi"> | ||
| <requires> | ||
| </requires> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@Rechi updated after xbmc/repo-resources#57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the SNES controller profile as a mandatory add-on. Let me be clear why:
The SNES controller is the archetypical retro controller. (Archetypical means "idealized model" or "most representative".) Indeed, it is the basis for the entire libretro controller abstraction.
That is why button combos in the GUI are shown using SNES buttons. In the future, we will show the button based on the controller in the user's hands. For first release, I hard-coded SNES buttons to keep things simple.
The first time the user is shown a button combo is the help dialog added in #14425. I made sure to include a large image so the user can visualize the button on their physical controller.
However, large images aren't helpful if they don't exist. Currently the user sees this empty dialog. This PR fixes that.
Motivation and Context
Forgot to include in #14425
How Has This Been Tested?
Tested as part of #14425
Screenshots (if appropriate):
After this PR: