[dns-cache] - fix dnscache lookup. The current code assumed that the …

…strIpAddress parameter was an empty string. That wasn't the case for e.x. nfs. In the case the nmblookup failed - but the caller has given a non-empty string in strIpAddress - this string was cached for the given hostname and returned back with return true. This fixes the problem by clearing the strIpAddress param before starting lookups. Thx to drloco for pointing it out.
xbmc · Nov 20, 2012 · 4cbe756 · 4cbe756 · theuni · Nov 20, 2012
1 parent 10bcf4f
commit 4cbe756
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/xbmc/network/DNSNameCache.cpp b/xbmc/network/DNSNameCache.cpp
@@ -40,6 +40,8 @@ bool CDNSNameCache::Lookup(const CStdString& strHostName, CStdString& strIpAddre
 {
   // first see if this is already an ip address
   unsigned long address = inet_addr(strHostName.c_str());
+  strIpAddress.Empty();
+
   if (address != INADDR_NONE)
   {
     strIpAddress.Format("%d.%d.%d.%d", (address & 0xFF), (address & 0xFF00) >> 8, (address & 0xFF0000) >> 16, (address & 0xFF000000) >> 24 );