Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't add xbmc.a to DIRECTORY_ARCHIVES
It gets added to MAINOBJS anyways, and adding it to DIRECTORY_ARCHIVES would mean that it also gets added to the tests, which would result in a double-definition of main () (one from xbmc and one from gtest). Instead, add it to xbmc.bin directly, as Darwin based platforms require such static linking.
- Loading branch information
7e8e1c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke xbmc.bin linkage on osx. MAINOBJS isn't used there and if it was used it would be incomplete (missing xbmc/main/osx/SDLMain.o) ... unsure how to do it right atm...
7e8e1c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake :)
7e8e1c9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if done in cmake that way it would be the same mess ...