-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixed: accept empty strings for the Input.SendText JSON-RPC call, as …
…they are perfectly valid input
- Loading branch information
bobo1on1
committed
Oct 13, 2012
1 parent
7493741
commit b23adb3
Showing
2 changed files
with
6 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b23adb3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the extra CVariant and the check whether it's a string or not. CJSONServiceDescription takes care of that and will throw an error at the JSON-RPC client if the "text" parameter is not a string. So basically you could have just dropped the
part. Plus you also need to make the same change you did to ServiceDescription.h in methods.json. I'll fix it up, just as an FYI.
b23adb3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap.