Skip to content

Commit

Permalink
Print the mirror redirected to for easier debugging of of mirror issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@Paxxi
Paxxi committed Jan 2, 2018
1 parent dc587bd commit de42ae8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion project/BuildDependencies/scripts/get_formed.cmd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ IF EXIST %1 (
) ELSE (
CALL :setSubStageName Downloading %1...
SET DOWNLOAD_URL=%KODI_MIRROR%/build-deps/win32/%1
%WGET% --quiet --tries=5 --retry-connrefused --waitretry=2 --show-progress "!DOWNLOAD_URL!" 2>&1
%WGET% -S --quiet --tries=5 --retry-connrefused --waitretry=2 --show-progress "!DOWNLOAD_URL!" 2>&1 | findstr /L /I "Location:"
REM Apparently there's a quirk in cmd so this means if error level => 1
IF ERRORLEVEL 1 (
ECHO %1^|Download of !DOWNLOAD_URL! failed >> %FORMED_FAILED_LIST%
Expand Down

5 comments on commit de42ae8

@Montellese
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this commit breaks downloading dependencies from some mirrors like https://ftp.acc.umu.se/mirror/xbmc.org/ because it does not send the Location header in the response. Furthermore you also break ERRORLEVEL which is evaluated further down because ERRORLEVEL is now the result of findstr instead of wget.

@Montellese
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried 8 different mirrors now and 2 of them returned the Location header but the other 6 didn't so they all fail when I explicitly set them using KODI_MIRROR.

@Paxxi
Copy link
Member Author

@Paxxi Paxxi commented on de42ae8 Jan 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I've seen a lot of failures as well but never looked into it. That's a really good catch.

You planning to PR it or should I do it?

@Montellese
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'll get to it this weekend so if you beat me to it be my guest.

@Montellese
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK looks like I beat you to it (after the weekend): #17231

Please sign in to comment.