Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Fix downloading dependencies from mirrors #17231

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

Montellese
Copy link
Member

@Montellese Montellese commented Jan 20, 2020

Description

This reverts commit de42ae8 see #13293
As mentioned in the comments in the commit it breaks downloading dependencies from any mirror which does not return the Location HTTP header. Furthermore it invalidates the value of ERRORLEVEL which now contains the return code of findstr instead of from wget.

Motivation and Context

When setting up my Windows 10 dev machine I noticed that lots of windows dependency downloads failed randomly and I had to restart download-dependencies.bat alot until I got all dependencies. Now when I setup the new windows build slave I ran into the same problem again. I then realized that from the 11 mirrors I tried

which leads to the download being considered as failed (for the second reason that's correct).

This should also be backported to Leia since it was introduced there and will also lead to build failures there.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

…ror issues"

This reverts commit de42ae8. It breaks
downloading dependencies from any mirror which does not return the "Location"
HTTP header. Furthermore it invalidates the value of ERRORLEVEL which now
contains the return code of findstr instead of from wget.
General (roadmap) automation moved this from In progress to Reviewer approved Jan 24, 2020
@Paxxi Paxxi merged commit 43b613a into xbmc:master Jan 24, 2020
General (roadmap) automation moved this from Reviewer approved to Done Jan 24, 2020
@Montellese Montellese deleted the bugfix/windows_depends_download branch January 24, 2020 23:34
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jan 27, 2020
…download

[windows] Fix downloading dependencies from mirrors
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
…download

[windows] Fix downloading dependencies from mirrors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants