Skip to content

Commit

Permalink
Merge pull request #25175 from garbear/fix-mapping-triggers
Browse files Browse the repository at this point in the history
Joysticks: Fix mapping PS4 trigger analog semiaxes
  • Loading branch information
garbear committed May 16, 2024
2 parents 4bf07f0 + 808b2bd commit de81598
Showing 1 changed file with 22 additions and 19 deletions.
41 changes: 22 additions & 19 deletions xbmc/input/joysticks/generic/ButtonMapping.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -451,31 +451,34 @@ bool CButtonMapping::MapPrimitive(const CDriverPrimitive& primitive)
{
bool bHandled = false;

auto now = std::chrono::steady_clock::now();

bool bTimeoutElapsed = true;

if (m_buttonMapper->NeedsCooldown())
bTimeoutElapsed = (now >= m_lastAction + std::chrono::milliseconds(MAPPING_COOLDOWN_MS));

if (bTimeoutElapsed)
{
bHandled = m_buttonMapper->MapPrimitive(m_buttonMap, m_keymap, primitive);

if (bHandled)
m_lastAction = std::chrono::steady_clock::now();
}
else if (m_buttonMap->IsIgnored(primitive))
if (m_buttonMap->IsIgnored(primitive))
{
bHandled = true;
}
else
{
auto duration = std::chrono::duration_cast<std::chrono::milliseconds>(now - m_lastAction);
auto now = std::chrono::steady_clock::now();

CLog::Log(LOGDEBUG, "Button mapping: rapid input after {}ms dropped for profile \"{}\"",
duration.count(), m_buttonMapper->ControllerID());
bHandled = true;
bool bTimeoutElapsed = true;

if (m_buttonMapper->NeedsCooldown())
bTimeoutElapsed = (now >= m_lastAction + std::chrono::milliseconds(MAPPING_COOLDOWN_MS));

if (bTimeoutElapsed)
{
bHandled = m_buttonMapper->MapPrimitive(m_buttonMap, m_keymap, primitive);

if (bHandled)
m_lastAction = std::chrono::steady_clock::now();
}
else
{
auto duration = std::chrono::duration_cast<std::chrono::milliseconds>(now - m_lastAction);

CLog::Log(LOGDEBUG, "Button mapping: rapid input after {}ms dropped for profile \"{}\"",
duration.count(), m_buttonMapper->ControllerID());
bHandled = true;
}
}

return bHandled;
Expand Down

0 comments on commit de81598

Please sign in to comment.