Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus "not available" dependency message with addons using built-in dependencies #14697

Closed
1 of 7 tasks
MilhouseVH opened this issue Oct 24, 2018 · 0 comments · Fixed by #15099
Closed
1 of 7 tasks

Bogus "not available" dependency message with addons using built-in dependencies #14697

MilhouseVH opened this issue Oct 24, 2018 · 0 comments · Fixed by #15099
Assignees
Labels
Component: Add-ons Resolution: Fixed issue was resolved by a code change v18 Leia
Milestone

Comments

@MilhouseVH
Copy link
Contributor

Bug report

This is originally trac #18062

Describe the bug

Kodi includes some pre-installed addons by default, and these are listed as "not available" when installing addons that have a dependency on the pre-installed addon.

This is going to lead to increased support overhead dealing with bogus issues.

Expected Behavior

Kodi should not list pre-installed addons as "not available".

Actual Behavior

Kodi lists pre-installed installed addons as "not available".

Possible Fix

LibreELEC/LibreELEC.tv#3057 - this is a workaround that may only be suitable for LibreELEC. A better solution that works for all operating systems is required.

To Reproduce

  1. Build latest Kodi master on Ubuntu.
  2. Run Kodi
  3. Go to Settings > Add-ons > Install from Repository > Program add-ons
  4. Click on Advanced MAME Launcher
  5. Click on Dependencies
    s1

The missing dependency is installed, enabled, and available:

neil@nm-linux:~/projects/kodi.git$ ls -la ./kodi-build/addons/script.module.pil/
total 12
drwxrwxr-x  2 neil neil 4096 Sep 23 23:18 .
drwxrwxr-x 53 neil neil 4096 Sep 23 23:18 ..
-rw-rw-r--  1 neil neil  421 Sep 23 23:18 addon.xml

s2

s3

Even though the dependency is reported as "not available", if the user ignores the "not available" message and proceeds with the add-on installation:

s4

then the add-on will be installed and work correctly with the allegedly "not available" dependencies. Kodi will continue to claim the dependency is missing even after installing the add-on...

Kodi appears to fail to find any "pre-installed" dependency when installing an add-on, which is going to lead to increased support overhead as we see this a lot with LibreELEC - we include script.module.pycrptodome (a dependency of Netflix etc.) and os.libreelec.tv (a dependency of various LibreELEC repository add-ons), both of which are misreported by Kodi as being "not available", generating unnecessary support issues.

Is there any way that Kodi can avoid mis-reporting pre-installed dependencies as not available when they are in fact available?

Your Environment

Used Operating system:

  • Android

  • iOS

  • Linux

  • OSX

  • Raspberri-Pi

  • Windows

  • Windows UWP

  • Operating system version/name: Ubuntu 17.10

  • Kodi version: Latest Kodi 18 master at the time of writing (94eff69)

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

@MilhouseVH MilhouseVH added this to To do in General (roadmap) via automation Oct 24, 2018
@MilhouseVH MilhouseVH removed this from To do in General (roadmap) Oct 24, 2018
yol pushed a commit that referenced this issue Dec 20, 2018
Current GUIDialogAddonInfo logic only displays a detailed entry in the
add-on dependency list if the add-on in question can be found in a
repository. Add-ons that are only available locally (pre-shipped with
Kodi or by distributor) such as script.module.pil in the default
installation are wrongly listed as "unavailable" even though they are
correctly found and enabled (if necessary) when installing the add-on.

In fact a locally available version is already looked up, but
completely disregarded if no repository version is found. This commit
fixes that situation by falling back to local add-on data if none
is found in the repositories.

Fixes #14697
@yol yol self-assigned this Dec 23, 2018
@yol yol added this to the Leia 18.0-rc4 milestone Dec 23, 2018
@yol yol added the Resolution: Fixed issue was resolved by a code change label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Add-ons Resolution: Fixed issue was resolved by a code change v18 Leia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants