Do not list non-repo add-ons as "unavailable" in info dialog #15099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current GUIDialogAddonInfo logic only displays a detailed entry in the add-on dependency list if the add-on in question can be found in a repository. Add-ons that are only available locally (pre-shipped with Kodi or by distributor) such as script.module.pil in the default installation are wrongly listed as "unavailable" even though they are correctly found and enabled (if necessary) when installing the add-on. In fact a locally available version is already looked up, but completely disregarded if no repository version is found. This commit fixes that situation by falling back to local add-on data if none is found in the repositories. Fixes #14697
yol
added
Type: Fix
|
@MilhouseVH please test |
|
@pkerling thanks, this is working great - tested on both LibreELEC and Ubuntu. Many thanks! |
|
@MartijnKaijser If possible I'd like to get a very quick look from any core dev acquainted with add-ons (@notspiff you around?) but I'm not sure this will happen in the next few days. Merge when you think it's time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current GUIDialogAddonInfo logic only displays a detailed entry in the
add-on dependency list if the add-on in question can be found in a
repository. Add-ons that are only available locally (pre-shipped with
Kodi or by distributor) such as script.module.pil in the default
installation are wrongly listed as "unavailable" even though they are
correctly found and enabled (if necessary) when installing the add-on.
In fact a locally available version is already looked up, but
completely disregarded if no repository version is found. This commit
fixes that situation by falling back to local add-on data if none
is found in the repositories.
Fixes #14697