Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: background file manager operations #1541

Merged
6 commits merged into from Oct 6, 2012
Merged

changed: background file manager operations #1541

6 commits merged into from Oct 6, 2012

Conversation

ghost
Copy link

@ghost ghost commented Oct 4, 2012

As in the topic. I could probably split this a bit if you insist, but it got so damm entangled..

@ghost
Copy link
Author

ghost commented Oct 4, 2012

this depends on pr #1530

@opdenkamp
Copy link
Member

nice

@ghost
Copy link
Author

ghost commented Oct 4, 2012

better split now and no longer depends on #1530

@jmarshallnz
Copy link
Contributor

Looks good to me. A few functions could be const (You asked for it by changing one that wasn't related...)

@ghost ghost self-assigned this Oct 4, 2012
@ghost
Copy link
Author

ghost commented Oct 4, 2012

hah, as if i'd ever do such a thing ;) put it in the correct context now + made the new functions const.

@ghost
Copy link
Author

ghost commented Oct 5, 2012

no other concerns?

@dersphere
Copy link
Contributor

If you are interested in a user opinion: I would like it even more if it would copy or move files one after another with any kind of queue and not parallel.

@ghost
Copy link
Author

ghost commented Oct 5, 2012

it's sorta what it does. it does two user-initiated operations in parallel. an operation can be copying n files or n dirs or whatever.

@dersphere
Copy link
Contributor

Oh, looks like I was not precise enough - sorry.
When I start copying file A and then start copying file B, both copy-jobs are done at the same time (and the progress window switches between the jobs).

@ghost
Copy link
Author

ghost commented Oct 5, 2012

i got you. if, however, you mark file a and file b and hit copy, they will be copied in sequence. doing it all in sequence is trivial, that's just removing the 2 thread slots. but imo this is better.

ghost pushed a commit that referenced this pull request Oct 6, 2012
changed: background file manager operations
@ghost ghost merged commit f69f18c into xbmc:master Oct 6, 2012
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants