Background CD ripper jobs #1530

Merged
2 commits merged into from Oct 4, 2012

2 participants

@ghost

Let the churn happen in the background while you browse through a stuttery library ;)

@ghost

i assume this is gonna get as much attention as cd rip stuff does normally, so;

@jmarshallnz please at least look at the first commit

@theuni
Team Kodi member

I looked through this yesterday and nothing jumped out, but i'm not familiar enough with ripping or jobs to be of much use on reviewing the logic of the change.

@ghost

there's really no logic change other than replace proggy dialog with ext proggy dialog. it's the same job. only other change is i had to add an option to cancel shit since that disappeared with the non-modal dialog, and that required the JobQueue change.

this will be followed by a pr backgrounding filemanager operations. it's done, i just have to polish it.

@jmarshallnz jmarshallnz and 1 other commented on an outdated diff Oct 4, 2012
xbmc/utils/JobManager.h
@@ -135,6 +135,10 @@ class CJobQueue: public IJobCallback
*/
virtual void OnJobComplete(unsigned int jobID, bool success, CJob *job);
+ /*!
+ \brief Returns whether or not the queue has any jobs
+ */
+ bool HasJobs();
@jmarshallnz
Team Kodi member
jmarshallnz added a line comment Oct 4, 2012

const? (I guess not due to the crit section?)

@ghost
ghost added a line comment Oct 4, 2012

yup..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jmarshallnz
Team Kodi member

Assigned to Oct

@ghost ghost was assigned Oct 4, 2012
@ghost Unknown referenced this pull request Oct 4, 2012
Merged

changed: background file manager operations #1541

spiff added some commits Oct 3, 2012
spiff changed: background cd ripper jobs
use the new CGUIDialogExtendedProgressBar (looks like java eh?)
to display progress
3f38605
spiff added: possibility to cancel backgrounded cd ripping jobs 47096e9
@ghost

now using isprocessing. pulling

@ghost ghost merged commit 91d656a into xbmc:master Oct 4, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment