Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background CD ripper jobs #1530

Merged
2 commits merged into from Oct 4, 2012
Merged

Background CD ripper jobs #1530

2 commits merged into from Oct 4, 2012

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2012

Let the churn happen in the background while you browse through a stuttery library ;)

@ghost
Copy link
Author

ghost commented Oct 4, 2012

i assume this is gonna get as much attention as cd rip stuff does normally, so;

@jmarshallnz please at least look at the first commit

@theuni
Copy link
Contributor

theuni commented Oct 4, 2012

I looked through this yesterday and nothing jumped out, but i'm not familiar enough with ripping or jobs to be of much use on reviewing the logic of the change.

@ghost
Copy link
Author

ghost commented Oct 4, 2012

there's really no logic change other than replace proggy dialog with ext proggy dialog. it's the same job. only other change is i had to add an option to cancel shit since that disappeared with the non-modal dialog, and that required the JobQueue change.

this will be followed by a pr backgrounding filemanager operations. it's done, i just have to polish it.

/*!
\brief Returns whether or not the queue has any jobs
*/
bool HasJobs();

This comment was marked as spam.

This comment was marked as spam.

@jmarshallnz
Copy link
Contributor

Assigned to Oct

@ghost ghost self-assigned this Oct 4, 2012
spiff added 2 commits October 5, 2012 01:09
use the new CGUIDialogExtendedProgressBar (looks like java eh?)
to display progress
@ghost
Copy link
Author

ghost commented Oct 4, 2012

now using isprocessing. pulling

ghost pushed a commit that referenced this pull request Oct 4, 2012
Background CD ripper jobs
@ghost ghost merged commit 91d656a into xbmc:master Oct 4, 2012
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants