Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag version pattern #19710

Closed
dev-0x7C6 opened this issue May 8, 2021 · 5 comments
Closed

Tag version pattern #19710

dev-0x7C6 opened this issue May 8, 2021 · 5 comments
Labels
Resolution: Fixed issue was resolved by a code change Triage: Confirmed issue has been reproduced by a team member v19 Matrix

Comments

@dev-0x7C6
Copy link

Hi, Is tagging pattern changed somehow? Tag for 19.1 is just v19.1but older versions was released under this pattern x.y-codename
@xbmc-gh-bot xbmc-gh-bot bot added Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it Ignored rules issue that does not follow the rules (no template, missing debug log, ...) labels May 8, 2021
@xbmc-gh-bot
Copy link

xbmc-gh-bot bot commented May 8, 2021

Thank you for using Kodi and our issue tracker. This is your friendly Kodi GitHub bot 😉

It seems that you have not followed the template we provide and require for all bug reports (or have opened a roadmap item by accident). Please understand that following the template is mandatory and required for the team to be able handle the volume of open issues efficiently.

Please edit your issue message to follow our template and make sure to fill in all fields appropriately. The issue will be closed after one week has passed without satisfactory follow-up from your side.

This is an automatically generated message. If you believe it was sent in error, please say so and a team member will remove the "Ignored rules" label.

@DaVukovic
Copy link
Member

You are correct. The tag is different from the others. I talked to @DaveTBlake. AFAIK there's no "rule" that the tag has to match some specific pattern, but maybe we can change it.

I do understand the problem if you have scripts which are expecting some specific kind of pattern.

@DaVukovic DaVukovic added Triage: Confirmed issue has been reproduced by a team member and removed Ignored rules issue that does not follow the rules (no template, missing debug log, ...) Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it labels May 9, 2021
@DaveTBlake
Copy link
Member

I'm a bit mystified why it came out like that, the release itself is 19.1-Matrix but the tag isn't. If it can be edited then I will, but I'm not sure that it can.

@DaveTBlake
Copy link
Member

OK, have created a tag 19.1-Matrix with same SHA and edited the release. Rather not delete or rename tags just in case in the few hours it has existed someone is using it. Extra tags are no harm.

Historically the tag name pattern has varied, and there are no rules per se, but my aim was to be consistent.

@DaveTBlake DaveTBlake added Resolution: Fixed issue was resolved by a code change v19 Matrix labels May 9, 2021
@dev-0x7C6
Copy link
Author

dev-0x7C6 commented May 9, 2021 •
edited

I do understand the problem if you have scripts which are expecting some specific kind of pattern.

In my case I have recipes yocto recipes with some version resolve logic.

Extra tags are no harm

Sure :)

Thanks for fixing this, I can maintain Yocto recipes without changing extra bits :) Keeping pattern will help package maintainers for sure.

@mweinelt mweinelt mentioned this issue May 16, 2021
Merged
10 tasks
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue May 16, 2021
@mweinelt
kodi: update git tag
d16ac1d 
Kodi dropped and renamed the tag for their latest release from v19.1 to
19.1-Matrix.

xbmc/xbmc#19710
peterhoeg pushed a commit to NixOS/nixpkgs that referenced this issue May 17, 2021
@mweinelt @peterhoeg
kodi: update git tag
fd899bd 
Kodi dropped and renamed the tag for their latest release from v19.1 to
19.1-Matrix.

xbmc/xbmc#19710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Fixed issue was resolved by a code change Triage: Confirmed issue has been reproduced by a team member v19 Matrix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DaVukovic @dev-0x7C6 @DaveTBlake