Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem playing Dolby Vision movies and series via streaming services #24171

Closed
1 of 7 tasks
Ronny-nerd opened this issue Dec 2, 2023 · 3 comments · Fixed by #24172
Closed
1 of 7 tasks

Problem playing Dolby Vision movies and series via streaming services #24171

Ronny-nerd opened this issue Dec 2, 2023 · 3 comments · Fixed by #24172
Labels
Platform: Android Resolution: Fixed issue was resolved by a code change v21 Omega

Comments

@Ronny-nerd
Copy link

Ronny-nerd commented Dec 2, 2023

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

Hello Kodi Team @fritsch or @ksooo,

Hadrware:
Nvidia Shield TV Pro 2019
LG OLED55B7D

Via streaming services (Netflix Addon, Amazon Prime Addon, Disney+ Addon) from kodi-20231124-940fe21f-master-arm64-v8a.apk and newer build = not OK = problems with 4K no Dolby Vision start icon on TV and when playing movies/series - black picture but sound is running.

Expected Behavior

Here is a clear and concise description of what was expected to happen:

Via streaming services (Netflix Addon, Amazon Prime Addon, Disney+ Addon) with kodi-20231122-8f075c53-master-arm64-v8a.apk and builds before that = OK = No problems even if you return from a newer build.

Actual Behavior

Via streaming services (Netflix Addon, Amazon Prime Addon, Disney+ Addon) Problems with 4K no Dolby Vision start icon on TV and when playing movies/series - black picture but sound is running.

kodi-20231124-940fe21f-master-arm64-v8a.apk = Not OK
kodi-20231127-b4ae12fe-master-arm64-v8a.apk = Not OK
kodi-20231128-4a41a5e4-master-arm64-v8a.apk = Not OK
kodi-20231130-12d991a5-master-arm64-v8a.apk = Not OK

Possible Fix

To Reproduce

Steps to reproduce the behavior:

Debuglog

The debuglog can be found here: https://paste.kodi.tv/irinahiyaf.kodi

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • macOS

  • Windows

  • Windows UWP

  • Operating system version/name: Android TV 11

  • Kodi version: Nightlies Kodi 21 Omega Beta1

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

@xbmc-gh-bot xbmc-gh-bot bot added the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label Dec 2, 2023
@neo1973
Copy link
Member

neo1973 commented Dec 2, 2023

Comparing the last good version with the first bad version (8f075c5...940fe21) it looks like #23577 could be the culprit.

@quietvoid
Copy link
Contributor

quietvoid commented Dec 2, 2023

I guess IS.A doesn't fill the AVDOVIDecoderConfigurationRecord so it's defaulting to zeroed which in turn sets the wrong codec profile..

I think we should just consider "valid" profiles as those being supported currently.
Dolby also says "Profiles 0–3 and 6 are not supported for new applications.".
So that would leave 4, 5, 7, 8 and 9.
In practice 99.99% of the files are 5, 7 or 8.

quietvoid added a commit to quietvoid/xbmc that referenced this issue Dec 2, 2023
When the AVDOVIDecoderConfigurationRecord is not valid, the fields are zeroed
and profile is set to 1, which is incorrect. It should default to profile 0.

Fixes xbmc#24171
quietvoid added a commit to quietvoid/xbmc that referenced this issue Dec 2, 2023
When the AVDOVIDecoderConfigurationRecord is not valid, the fields are zeroed
and profile is set to 1, which is incorrect. It should default to profile 0.

Fixes xbmc#24171
@Ronny-nerd
Copy link
Author

I would like to thank the Kodi team very much with the new build which was made this morning, it works again with the 4K Dolby Vision icon on the TV as well as movies and series...they are now played again without any problems.

https://jenkins.kodi.tv/job/android-arm64-docker/4326/

screenshot

@thexai thexai added the Resolution: Fixed issue was resolved by a code change label Dec 3, 2023
@neo1973 neo1973 removed the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label Dec 3, 2023
78andyp pushed a commit to 78andyp/xbmc that referenced this issue Dec 19, 2023
When the AVDOVIDecoderConfigurationRecord is not valid, the fields are zeroed
and profile is set to 1, which is incorrect. It should default to profile 0.

Fixes xbmc#24171
heitbaum pushed a commit to heitbaum/xbmc that referenced this issue Dec 28, 2023
When the AVDOVIDecoderConfigurationRecord is not valid, the fields are zeroed
and profile is set to 1, which is incorrect. It should default to profile 0.

Fixes xbmc#24171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android Resolution: Fixed issue was resolved by a code change v21 Omega
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants