Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Ignore obsolete DOVI profiles from codec selection #24172

Merged
merged 1 commit into from Dec 3, 2023

Conversation

quietvoid
Copy link
Contributor

@quietvoid quietvoid commented Dec 2, 2023

Description

When the AVDOVIDecoderConfigurationRecord is not valid, the fields are zeroed and profile is set to 1, which is incorrect. It should default to profile 0.

Fixes #24171.

Motivation and context

Fixes Dolby Vision playback when file hints are not provided by FFmpeg demuxer.
In Dolby's specifications it also says Profiles 0–3 and 6 are not supported for new applications.

How has this been tested?

Not tested.

What is the effect on users?

Corrects playback of videos through streaming addons.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

When the AVDOVIDecoderConfigurationRecord is not valid, the fields are zeroed
and profile is set to 1, which is incorrect. It should default to profile 0.

Fixes xbmc#24171
@quietvoid quietvoid changed the title [Android] Remove obsolete DOVI profiles from codec selection [Android] Ignore obsolete DOVI profiles from codec selection Dec 2, 2023
@thexai thexai added this to the Omega 21.0 Beta 2 milestone Dec 3, 2023
@thexai
Copy link
Member

thexai commented Dec 3, 2023

jenkins build this please

@thexai thexai merged commit 2a28a56 into xbmc:master Dec 3, 2023
2 checks passed
@quietvoid quietvoid deleted the dovi_obsolete_profiles branch December 3, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem playing Dolby Vision movies and series via streaming services
3 participants