-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[estuary] another sync, misc fixes / additions #10646
Conversation
@@ -1,6 +1,6 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<window> | |||
<defaultcontrol>1000</defaultcontrol> | |||
<defaultcontrol>996</defaultcontrol> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
looking good |
Are the changes to Wall and Infowall views intentional? I (and others) preferred the original more compact layouts... Here's Wall: And InfoWall: |
yup, change was made because now it supports thumbs with non-poster format (was requested several times on forums and makes sense for a default skin imo) |
Personally I preferred the more compact look as all of my thumbs are posters. Now, it just looks a lot less neat with so much wasted space. However as it's intentional I guess the discussion should continue in the Estuary forum - I'll make a post and then you can gauge the feedback. |
ok, cool. |
OK, if you've changed it already there's no point me posting the current (new) look on the forum (I was in the process of uploading the old/new look to an imgur gallery, and failing!), but I do think this may need wider discussion before committing to these changes - I don't really see the point of adding the extra text below the thumbs in these Wall/InfoWall views, as to me a "Wall" view should just be about the artwork, with as much artwork visible as possible. Having to support non-poster thumbs now means that the majority of artwork (typically posters) is now surrounded by blank space. If there's a need to support non-poster artwork then maybe it should be done with a new/extra view? The revised Wall view is better, but that text... hmmm. :) |
Can we get the old Wall view back? For me the new look is terrible.. No need for that Background and text. Make it optional ;) |
Just adding my support to removing the year from title. It is unnecessary on that view. |
+1 for previous wall and infowall versions |
+1 for previous poster only option please! |
@ronie