[cmake] Fix building main executable #10694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target_link_libraries command with PUBLIC for lib${APP_NAME_LC}
already propagates the libraries to the main binary, there's no need
to add them a second time.
When building for android 'make kodi' couldn't build the shared libraries (as it was causing a circular dependency). This has been resolved with xbmc@88f02f2.
fetzerch
force-pushed
the
cmake_linking
branch
from
ded66fe
to
4e740e3
Compare
hudokkow
approved these changes
Oct 12, 2016
|
Build errors in travis unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make kodion android will be enough to compile libkodi.so and all shared libraries.build: http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-All/1659/
pings: @wsnipex, @hudokkow