[gui] dialogvideoinfo: show selectdialog for directorbutton if amount of directors > 1 #10776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhaggi
requested changes
Oct 26, 2016
| pDlgSelect->Add(director); | ||
| pDlgSelect->Open(); | ||
|
|
||
| auto iItem = pDlgSelect->GetSelectedItem(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
| else | ||
| { | ||
| auto strDirector = StringUtils::Join(m_movieItem->GetVideoInfoTag()->m_director, g_advancedSettings.m_videoItemSeparator); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if (iItem < 0) | ||
| return true; | ||
| OnSearch(directors[iItem]); | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
nice, i like the idea +1 |
… of directors > 1
phil65
force-pushed
the
director_selectdialog
branch
from
5957a88
to
3bc1377
Compare
|
@xhaggi updated. |
phil65
added
Type: Fix
|
jenkins build this please. |
|
Jenkins doesnt listen.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Director button in videoinfo dialog doesnt work in case the amount of directors is > 1.
This fixes those cases by showing a selectdialog before the actual search which allows to choose between all available directors.
@ronie @xhaggi