[xbmc][fix] Don't try to index outside our lookup table and crash

[Paxxi]

The lookup table was miscalculated and one chunk too small causing us to index outside of it and return garbage when using the style font_light + font_bold + font_italic = 7

Description

Increase the lookup table to be 256*8 instead of 256*7 and add a guard against this happening again by actually checking our index against our table size

Motivation and Context

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the Code guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the CONTRIBUTING document
• I have added tests to cover my change
• All new and existing tests passed

[phil65]

Thx for lookin into it, @Paxxi !
@enen92 fyi.

[arnova]

Nice catch

[MartijnKaijser]

jenkins build this please

[MilhouseVH]

Build failure on Linux, looks like LOOKUPTABLE_SIZE will only be available on Windows (#ifdef HAS_DX):

In file included from GUIFont.cpp:22:0:
GUIFontTTF.h:162:26: error: ‘LOOKUPTABLE_SIZE’ was not declared in this scope
   Character *m_charquick[LOOKUPTABLE_SIZE];     // ascii chars (7 styles) here
                          ^
make[1]: *** [GUIFont.o] Error 1

[Paxxi]

@MilhouseVH yeah, I totally missed that ifdef, should be fixed now

[Paxxi]

jenkins build this please

[enen92]

Thanks for the fix @Paxxi