added: make CFileItemList iterable

[notspiff]

This makes CFileItemList iterable, i.e.

for (auto& it : CFileItemListInstance)

[Montellese]

Thanks a lot for this. I was always too lazy to do it :-/

[akva2]

On purpose. We do not want a mutable iterator, CFileItemList is based on Add () paradigm. The compiler is smart enough but if you want explicit you shall have explicit give me 15mins to get home .

[akva2]

meh. you are of course completely correct, my left hand had forgotten to commit the const versions which i realized was needed after testing. i thought you were (only) referring to begin() and end() returning const iterators wanting cbegin cend non-const overloads when i wrote ^^ (and obviously i "read" your comment too fast..). i did learn something new though - the compiler will not consider non-const overloads of cbegin|cend at all.

i have kept the code that was there and added the missing cbegin() cend() implementations. if you want mutable iteration, just say so. i gave my reasoning above, it just seemed to break surrounding design to me.

[Montellese]

No I don't want mutable iterators because it will break stuff that works when using Add() and Remove(). I was just confused about the naming. But I didn't consider that when I wrote my comment so it wasn't 100% correct either.

[hudokkow]

jenkins build this please

[MartijnKaijser]

Should there be any updates/changes or can this be merged?

[notspiff]

as far as i am concerned it should be as ok. i need the explicit begin() / end() because the compiler is too stupid to constify on its own (i.e. if the CFileItemList is not in a const context it won't consider cbegin() / cend()).

[Paxxi]

jenkins build and merge this please

[Montellese]

Let's try again. jenkins build and merge this please

[Montellese]

Just gave it a try and it doesn't work in all cases. E.g. when I have a const CFileItemList I cannot use the for-range because there's no begin() const and end() const (returning a const_iterator). I also checked the implementation of std::vector and there you have

• begin() and end()
• begin() const and end() const
• cbegin() const and cend() const

so we are missing the begin() const and end() const. Mind providing a follow up PR?