Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated infobools #11058

Merged
merged 1 commit into from
Dec 12, 2016
Merged

remove deprecated infobools #11058

merged 1 commit into from
Dec 12, 2016

Conversation

ronie
Copy link
Member

@ronie ronie commented Dec 5, 2016

remove deprecated stringcompare infobools.

@ronie ronie added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality API change: GUI v18 Leia labels Dec 5, 2016
@ronie
Copy link
Member Author

ronie commented Dec 5, 2016

jenkins build this please

@ronie ronie requested a review from xhaggi December 12, 2016 02:17
xhaggi
xhaggi approved these changes Dec 12, 2016
View reviewed changes
Copy link
Member

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Dec 12, 2016
@MartijnKaijser MartijnKaijser merged commit 541576b into xbmc:master Dec 12, 2016
@ksooo
Copy link
Member

ksooo commented Dec 13, 2016

This PR seems to cause serious trouble: http://forum.kodi.tv/showthread.php?tid=298461&pid=2477340#pid2477340

@BigNoid
Copy link
Member

BigNoid commented Dec 13, 2016 •
edited
Loading

Estuary still has some deprecated infobools: https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/DialogSeekBar.xml#L3
https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/Custom_1109_TopBarOverlay.xml#L29
https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/Variables.xml#L190

see #11156

@AlwinEsch
Copy link
Member

This breaks also the skins on pvr.vdr.vnsi.

AlwinEsch
AlwinEsch reviewed Dec 14, 2016
View reviewed changes
xbmc/GUIInfoManager.cpp
// should be removed before L*** v18
if (cat.name == "isempty" && cat.num_params() == 1)
return AddMultiInfo(GUIInfo(STRING_IS_EMPTY, TranslateSingleString(cat.param(), listItemDependent)));
else if (cat.name == "stringcompare" && cat.num_params() == 2)

This comment was marked as spam.

Sign in to view

@ronie
Copy link
Member Author

ronie commented Dec 14, 2016

then those skins need to be updated as well ;-)

you need to use String.IsEqual() in that case

@AlwinEsch
Copy link
Member

Thanks a lot! :D

AlwinEsch added a commit to AlwinEsch/pvr.vdr.vnsi that referenced this pull request Dec 14, 2016
@AlwinEsch
fix skins after Kodi change xbmc/xbmc#11058
1643f6d
@ronie ronie deleted the stringcompare-cleanup branch January 11, 2017 15:42
@razzeee razzeee mentioned this pull request Jul 4, 2017
Merged
@enen92
Copy link
Member

enen92 commented Nov 16, 2018

@ronie found this comment while going through the infolabels docs:
https://github.com/xbmc/xbmc/blob/master/xbmc/GUIInfoManager.cpp#L6716

Since IntegerGreaterThan has been removed, is this still usefull?

@ronie
Copy link
Member Author

ronie commented Nov 16, 2018

IntegerGreaterThan() was replaced by Integer.IsGreater(), so i guess the code is still useful..

@enen92
Copy link
Member

enen92 commented Nov 17, 2018

True. Sorry for the noise. I'll update the comment to refer to the correct infobool and avoid future confusion

This was referenced Jun 9, 2019
Closed
Closed
This was referenced Jul 25, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlwinEsch AlwinEsch AlwinEsch left review comments

@xhaggi xhaggi xhaggi approved these changes

Assignees
No one assigned
Labels
API change: GUI Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.
7 participants
@ronie @ksooo @BigNoid @AlwinEsch @enen92 @xhaggi @MartijnKaijser