Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] remove old code for viewtype parsing #11114

Merged
merged 1 commit into from
Dec 18, 2016
Merged

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Dec 11, 2016

Removes the old-school way of adding viewtypes to mediawindows (without <views>tag). I´m quite sure this isnt used anymore at all.
@ronie

@phil65 phil65 force-pushed the rem_old_shit branch 2 times, most recently from 648fdcf to 86e6753 Compare December 11, 2016 04:05
@MartijnKaijser
Copy link
Member

might want to make the commit message a bit more descriptive ;)

@ronie
Copy link
Member

ronie commented Dec 11, 2016

i think you pushed the wrong branch?

@phil65
Copy link
Contributor Author

phil65 commented Dec 11, 2016

oops, yes, sorry. I blame alcohol.
Will fix.

@phil65
Copy link
Contributor Author

phil65 commented Dec 11, 2016

fixed.

@ronie
Copy link
Member

ronie commented Dec 11, 2016

yup, get rid of it.

@phil65
Copy link
Contributor Author

phil65 commented Dec 11, 2016

jenkins build this please.

@phil65 phil65 merged commit e57386f into xbmc:master Dec 18, 2016
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 18, 2016
@MartijnKaijser MartijnKaijser added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: GUI engine v18 Leia labels Dec 18, 2016
@phil65 phil65 deleted the rem_old_shit branch December 18, 2016 20:12
@ronie ronie mentioned this pull request Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants