Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MusicPlaylistEditor #12879

Merged
merged 1 commit into from
Oct 10, 2017
Merged

fix MusicPlaylistEditor #12879

merged 1 commit into from
Oct 10, 2017

Conversation

ronie
Copy link
Member

@ronie ronie commented Oct 3, 2017

the removal of the automatic view detection code in #11114 broke the MusicPlaylistEditor window.

this can easily be fixed by adding an explicit view id definition to the skin xml file.

@phil65

@ronie ronie added Type: Fix non-breaking change which fixes an issue Component: Skin labels Oct 3, 2017
@DaveTBlake
Copy link
Member

Thanks for this @ronie despite being music I had not noticed, then again I don't use playlists much.

@phil65
Copy link
Contributor

phil65 commented Oct 8, 2017

Interesting, I didnt know that MyMusicPlaylistEditor.xml is a MediaWindow. Seems to be a weird choice for that imo.
Thx for fixing it!

@ronie ronie merged commit 6a09c7b into xbmc:master Oct 10, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Oct 10, 2017
@ronie ronie deleted the 11114-fallout branch May 7, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants