Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AML] read display modes optionally from file #11159

Merged
merged 1 commit into from Dec 13, 2016

Conversation

Projects
None yet
5 participants
@peak3d
Copy link
Contributor

commented Dec 13, 2016

[AML] read display modes optionally from file

Description

AML often looses the settings in /sys/class/amhdmitx/amhdmitx0/disp_cap.
In case of failure they are either empty or contain only 720p and 1080p (on my odroid)
This PR looks first for the existance of a file, if present it uses the values in there, otherwise the information is used from /sys/class/amhdmitx/amhdmitx0/disp_cap

Motivation and Context

1.) Loosing EDID information is annoying because no framerate adjustment occurs
2.) My EDID information does not contain 24hz, Using this file let me force the monitor to it.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@codesnake

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2016

@peak3d In your case does the monitor provide wrong EDID, or just AML kernel interprets it incorrectly?

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2016

@codesnake from syslog its wrong EDID (parse errors) and it leads to a 2 liner (720p + 1080p).
If the EDID can be parsed correctly (~10 lines), the 24HZ are missing / not available.

I know that it could be an issue of cable, but sometimes I start device with monitor off. This leads to missing modes as well. With the file I'm happy now :-)

Pls refer to this discussion here:

6c48936

@codesnake

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2016

I just mean that if this is an HDMI driver issue, then it should be fixed there, not in Kodi. If you start your device with monitor off, the driver should (and it is) read the EDID when you turn on the monitor.

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2016

I don't know what kind of issue it is, but regarding the other PR it seems to be an issue I'm not alone with.
Beside this: I need the 24Hz for testing.

This PR is not a fix of anything, beside the fact that I (and others) have issues with EDID and / or missing modes its a feature PR here.

@fritsch

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

@fritsch

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2016

sorry for jumping in, but at least https://github.com/LibreELEC/LibreELEC.tv/blob/master/projects/WeTek_Play/patches/kodi/0004-aml-Fill-audio-packets-completely-when-resampling-to.patch is not needed anymore for aml 3.14 (EDIT: LibreELEC, that's what I use) kernel

@peak3d peak3d merged commit 35d342a into xbmc:master Dec 13, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peak3d peak3d deleted the peak3d:amldisp_cap branch Dec 13, 2016

@codesnake

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2016

@fritsch That's why I never PRed the above mentioned patches upstream, because they are just workarounds, not real fixes.

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2016

@codesnake @fritsch I'll revert this PR soon and will allow additional modes be set in the advanced_settings.xml file. The settings in advanced..... are merged to the modes read from disp_cap.

@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.