Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] core_add_test_library also add headers to IDE #11160

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Dec 13, 2016

Motivation and Context

Header files for tests were missing in Visual Studio.

How Has This Been Tested?

cmake generation

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@wsnipex
Copy link
Member

wsnipex commented Dec 15, 2016

looks good to me, @fetzerch ping

@fetzerch
Copy link
Member

fetzerch commented Dec 15, 2016

It should be fine, not hundert percent sure if GTEST_ADD_TESTS (in main cmakelists.txt) will be ok, but jenkins will tell - hopefully ;)

jenkins build this please

@Rechi
Copy link
Member Author

Rechi commented Dec 20, 2016

any objections on this?

@wsnipex wsnipex merged commit 2b66913 into xbmc:master Dec 20, 2016
@Rechi Rechi deleted the cmakeTestHeaders branch December 20, 2016 08:34
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants