Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win] always link with Windows Sockets #11248

Merged
merged 1 commit into from
Dec 22, 2016
Merged

[win] always link with Windows Sockets #11248

merged 1 commit into from
Dec 22, 2016

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Dec 22, 2016

Description

Always link with Windows Sockets 2 on windows.

Motivation and Context

forgotten in #11237
If building without MicroHttpd there are unresolved symbols when linking kodi or kodi-test.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Paxxi Paxxi merged commit d4dd65b into xbmc:master Dec 22, 2016
@Paxxi
Copy link
Member

Paxxi commented Dec 22, 2016

Thanks! Keep them coming ☺️

@Rechi Rechi deleted the winSockets branch December 22, 2016 16:07
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CMake Platform: Windows v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rechi @Paxxi @MartijnKaijser