Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake|win32] allow webserver to be disabled on windows #11237

Merged
merged 2 commits into from
Dec 21, 2016

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Dec 21, 2016

Description

The defines HAS_WEB_SERVER and HAS_WEB_INTERFACE are already defined if HAVE_LIBMICROHTTPD is defined. There is no need to generally set it for windows.
TestWebServer must only be compiled if the HTTPRequestHandlers are build.

How Has This Been Tested?

Compiled on Windows with disabled microhttpd.

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@fetzerch fetzerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! When I started with cmake on windows, I found a few places with #pragma lib that might have become obsolete now.

@fetzerch
Copy link
Member

jenkins build and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants