Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StringUtils] Fix SecondsToTimeString() for negative values #11360

Merged
merged 1 commit into from
Jan 17, 2017
Merged

[StringUtils] Fix SecondsToTimeString() for negative values #11360

merged 1 commit into from
Jan 17, 2017

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Jan 3, 2017

Atm Player.SeekTime can show really weird values when seeking "behind" 0 or totalplaytime.
This commit makes sure that 0 <= Player.Seektime <= totalplaytime.
@FernetMenta

@FernetMenta
Copy link
Contributor

the assuption that minimum displayed time is zero is not correct. the issue is caused by seekhandler and has to be fixed there.

@phil65
Copy link
Contributor Author

phil65 commented Jan 16, 2017

Agreed, should be fixed at the root.
So I think we basically need two fixes:

  • SeekHandler method GetSeekSize() should only return values within the appropriate range
  • StringUtils::SecondsToTimeString() needs to deal correctly with negative values.

Changed this PR to fix the second part, SeekHandler is not my territory :)

@FernetMenta

@phil65 phil65 changed the title [gui] Player.SeekTime should only get values from 0 to TotalPlayTime [StringUtils] Fix SecondsToTimeString() for negative values Jan 16, 2017
@FernetMenta
Copy link
Contributor

looks ok to me

@phil65
Copy link
Contributor Author

phil65 commented Jan 17, 2017

jenkins build this please.

@phil65 phil65 merged commit a36ac10 into xbmc:master Jan 17, 2017
@phil65 phil65 deleted the currentseektime branch January 17, 2017 13:51
@phil65 phil65 mentioned this pull request Jan 19, 2017
Merged
MartijnKaijser added a commit that referenced this pull request Jan 21, 2017
@MartijnKaijser
Merge pull request #11493 from phil65/krypton_backports
0e7c42e 
Backports for #11421 and #11360
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 21, 2017
@MartijnKaijser MartijnKaijser added Backport: Done Type: Fix non-breaking change which fixes an issue v18 Leia labels Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phil65 @FernetMenta @MartijnKaijser