[FavouritesDirectory] fix for adding addons to favourites via addonbrowser #11421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montellese
requested changes
Jan 11, 2017
| @@ -197,8 +197,15 @@ std::string CFavouritesDirectory::GetExecutePath(const CFileItem &item, const st | |||
| execute = StringUtils::Format("ActivateWindow(%s,%s,return)", contextWindow.c_str(), StringUtils::Paramify(item.GetPath()).c_str()); | |||
| } | |||
| //! @todo STRING_CLEANUP | |||
| else if (item.IsScript() && item.GetPath().size() > 9) // plugin://<foo> | |||
| else if (StringUtils::StartsWith(item.GetPath(), "script://")) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| execute = StringUtils::Format("RunScript(%s)", StringUtils::Paramify(item.GetPath().substr(9)).c_str()); | ||
| else if (StringUtils::StartsWith(item.GetPath(), "plugin://")) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| execute = StringUtils::Format("RunScript(%s)", StringUtils::Paramify(item.GetPath().substr(9)).c_str()); | ||
| else if (StringUtils::StartsWith(item.GetPath(), "plugin://")) | ||
| execute = StringUtils::Format("PunPlugin(%s)", StringUtils::Paramify(item.GetPath().substr(9)).c_str()); | ||
| else if (item.IsAddonsPath()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@Montellese updated. |
|
jenkins build this please. |
tamland
reviewed
Jan 11, 2017
| execute = StringUtils::Format("RunScript(%s)", StringUtils::Paramify(item.GetPath().substr(9)).c_str()); | ||
| else if (item.IsPlugin() && item.GetPath().size() > 9) // plugin://<foo> | ||
| execute = StringUtils::Format("PunPlugin(%s)", StringUtils::Paramify(item.GetPath().substr(9)).c_str()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
updated. |
phil65
force-pushed
the
fav_addons
branch
2 times, most recently
from
f938749
to
0e28538
Compare
|
jenkins build this please. |
|
worth a backport? |
Rechi
reviewed
Jan 12, 2017
| else if (item.IsAddonsPath() && item.GetPath().size() > 9) // addons://<foo> | ||
| { | ||
| CURL url(item.GetPath()); | ||
| execute = StringUtils::Format("RunAddon(%s)", url.GetFileName()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please. |
MartijnKaijser
added
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some scenarios where adding addons as favourites doesnt work properly.
@tamland