Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling: compiler defines #11366

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 4, 2017

Description

Fix spelling for compiler defines

Motivation and Context

How Has This Been Tested?

  • Travis
  • AppVeyor

Screenshots (if appropriate):

Types of change

  • Spelling

Checklist:

@jsoref
Copy link
Contributor Author

jsoref commented Jan 4, 2017

Split from #11346 ; @AlwinEsch: if you want, I can adjust whitespace...

@jsoref jsoref force-pushed the spelling-defines branch 3 times, most recently from d05d53c to 07c0cfe Compare January 4, 2017 14:15
Copy link
Member

@Jalle19 Jalle19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked all the build scripts etc. in case any of these are used there?

@notspiff
Copy link
Contributor

notspiff commented Jan 9, 2017

none of these are exported from the compile units (apart from the trivial header guard and string change), so it shouldn't be able to break any build scripts.

@Jalle19
Copy link
Member

Jalle19 commented Jan 9, 2017

jenkins build this please

@Paxxi
Copy link
Member

Paxxi commented Jan 14, 2017

jenkins build and merge this please

@MartijnKaijser MartijnKaijser added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Jan 14, 2017
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 14, 2017
@MartijnKaijser
Copy link
Member

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 1d06241 into xbmc:master Jan 14, 2017
@jsoref jsoref deleted the spelling-defines branch January 15, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants