Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SMB File Rename if same share #11445

Closed
wants to merge 1 commit into from
Closed

Add support for SMB File Rename if same share #11445

wants to merge 1 commit into from

Conversation

fedux
Copy link
Contributor

@fedux fedux commented Jan 14, 2017

Description

If the file to be moved in ActionMove is in the same SMB share it can be renamed.

Motivation and Context

Copying a file instead of renaming is inefficient as it has to be transferred twice over the network. This makes move operations a server side operation.

How Has This Been Tested?

Tested in my own setup.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Paxxi
Copy link
Member

Paxxi commented Jan 14, 2017

Thank you. Krypton is feature complete at this point so I don't think it's a good idea to merge this.

We rely on several different smb implementations so ensuring that this does not introduce any bugs takes a lot of effort.
We currently build against, Native windows, smb pre-gpl3, smb gold, libdsm that I know of.

Seems like a good candidate to include in master though where it has time to get proper testing.

If the file to be moved in ActionMove is in the same SMB share it can be renamed.
@fedux fedux changed the base branch from Krypton to master January 14, 2017 12:20
@fedux
Copy link
Contributor Author

fedux commented Jan 14, 2017

Fair enough, rebased onto master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants