Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SetShellVarContext from current to all #11809

Merged
merged 1 commit into from
Mar 5, 2017

Conversation

kwade00
Copy link
Contributor

@kwade00 kwade00 commented Mar 5, 2017

Description

Changed one line in the Installer section and one line in the Uninstaller section. SetShellVarContext was set to 'current'; changed so that it sets to 'all'.

Motivation and Context

SetShellVarContext tells the installer whether to perform the install for all users or just the current user. Since we require admin privileges for installation, it makes the most sense and fits with Windows standards to peform the installation for all users. This will put the shortcuts in the all users menu and the uninstall registry entries in the all users area of the registry.

How Has This Been Tested?

I do not have a worthy machine for testing, but the change is a very simple NSIS script change.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@Paxxi Paxxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Paxxi Paxxi added the Type: Improvement non-breaking change which improves existing functionality label Mar 5, 2017
@Paxxi Paxxi added this to the L 18.0-alpha1 milestone Mar 5, 2017
@Paxxi Paxxi merged commit bdcdaa7 into xbmc:master Mar 5, 2017
@Paxxi
Copy link
Member

Paxxi commented Mar 5, 2017

thank you @kwade00 , very much appreciated!

@MartijnKaijser
Copy link
Member

@kwade00 could you PR the same change to Krypton branch?

@kwade00
Copy link
Contributor Author

kwade00 commented Mar 6, 2017

Done. #11815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Platform: Windows Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants