Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHANGELOG if not exist #11813

Merged
merged 2 commits into from Mar 9, 2017

Conversation

@Cyr-ius
Copy link
Contributor

commented Mar 5, 2017

CPACK - Variable CHANGELOG if not exist

Description

When build old version , changelog is empty , because git list since last month.

Motivation and Context

Fix this.

How Has This Been Tested?

CPack old version Krypton 17.0 is OK

Screenshots (if appropriate):

Types of change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X ] My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • [] I have added tests to cover my change
  • All new and existing tests passed
@wsnipex

This comment has been minimized.

Copy link
Member

commented Mar 6, 2017

could you fix the git log --since so that it always returns something instead?
--since="30 days ago" should work

@Cyr-ius

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2017

OK , i changed. It works.

@wsnipex wsnipex merged commit 924911c into xbmc:master Mar 9, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Rechi Rechi added this to the L 18.0-alpha1 milestone Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.