Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osx] - add the minimum required osx version to the info.plist - this… #11932

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

Memphiz
Copy link
Member

@Memphiz Memphiz commented Apr 4, 2017

… will show a message box on startup when minimum osx version is not installed (also mentioning the needed minimum osx version)

Description

Ensure that the bundle can't be started on to old osx versions

Motivation and Context

To many users post crash reports due to unsupported osx versions. Its much better to use the osx feature here which will present the user with a message box that the minimum osx version is not present

How Has This Been Tested?

This simply sets the osx deployment target as minimum osx version in the info.plist. Tested via generating the info.plist and adding it to a kodi bundle (editing to some very high osx version that is newer then the one i have installed). Results as expected in a dialog telling me i need a newer version for running Kodi.

Screenshot

https://www.dropbox.com/s/fdgnxsbbtv4ln3a/osxminversion_dialog.png?dl=0

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

… will show a message box on startup when minimum osx version is not installed (also mentioning the needed minimum osx version)
@Memphiz
Copy link
Member Author

Memphiz commented Apr 4, 2017

Tested on jenkins - http://mirrors.kodi.tv/test-builds/osx/x86_64/kodi-20170404-d37c137-osx_minversion-x86_64.dmg (verified that Info.plist in the bundle has the correct minimum version of 10.8 set).

@Memphiz Memphiz merged commit c0cc060 into xbmc:master Apr 4, 2017
@Memphiz Memphiz deleted the osx_minversion branch April 4, 2017 21:41
@Rechi Rechi added this to the L 18.0-alpha1 milestone Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Platform: macOS Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants