[filesystem] ZipManager: skip path traversal #12024

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
5 participants
@Rechi
Member

Rechi commented Apr 28, 2017

Description

Skip items in a zip file, which try to traverse to a parent directory.
Backport of #12023

Motivation and Context

Without this a zip file can override every file the current user has write permission.

How Has This Been Tested?

Tested with a malicious zip file.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the Krypton 17.2-RC1 milestone Apr 28, 2017

@Rechi

This comment has been minimized.

Show comment
Hide comment
@Rechi

Rechi May 10, 2017

Member

updated to be equal with #12023

Member

Rechi commented May 10, 2017

updated to be equal with #12023

@MartijnKaijser

This comment has been minimized.

Show comment
Hide comment
@MartijnKaijser

MartijnKaijser May 10, 2017

Member

jenkins build this please

Member

MartijnKaijser commented May 10, 2017

jenkins build this please

@MartijnKaijser

This comment has been minimized.

Show comment
Hide comment
@MartijnKaijser

MartijnKaijser May 10, 2017

Member

jenkins build this please

Member

MartijnKaijser commented May 10, 2017

jenkins build this please

@Rechi

This comment has been minimized.

Show comment
Hide comment
@Rechi

Rechi May 11, 2017

Member

jenkins build this please

Member

Rechi commented May 11, 2017

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 089bed6 into xbmc:Krypton May 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
default You're awesome. Have a cookie
Details

@Rechi Rechi deleted the Rechi:zipTraversalKrypton branch May 11, 2017

@ghost ghost referenced this pull request in koying/SPMC May 23, 2017

Open

Subtitle hack ->Soon new updated version of Jarvis? #905

@iguana007 iguana007 referenced this pull request in osmc/osmc May 24, 2017

Closed

Subtitles hack #368

@racer1988

This comment has been minimized.

Show comment
Hide comment
@racer1988

racer1988 May 24, 2017

Hello,

is this already available here?
https://kodi.tv/download

I see it is in the milestone and from https://kodi.tv/download seems that 17.2 has been released also there.

I just wanted to double check.
(also it is all on all platforms right?)

racer1988 commented May 24, 2017

Hello,

is this already available here?
https://kodi.tv/download

I see it is in the milestone and from https://kodi.tv/download seems that 17.2 has been released also there.

I just wanted to double check.
(also it is all on all platforms right?)

@racer1988

This comment has been minimized.

Show comment
Hide comment
@razvansalajan

This comment has been minimized.

Show comment
Hide comment
@razvansalajan

razvansalajan Jun 19, 2017

Hi,

I will make a presentation about Hacked in translation at one of my computer science courses. I would like also to reproduce the bug with a zip file. Could any of you guys can help me out with a malicious zip file?

Hi,

I will make a presentation about Hacked in translation at one of my computer science courses. I would like also to reproduce the bug with a zip file. Could any of you guys can help me out with a malicious zip file?

@stefansaraev

This comment has been minimized.

Show comment
Hide comment
@stefansaraev

stefansaraev Jun 19, 2017

Contributor

@razvansalajan sorry for being harsh on you, but you should be able to make one yourself.

Contributor

stefansaraev commented Jun 19, 2017

@razvansalajan sorry for being harsh on you, but you should be able to make one yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment