Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] copy_files_from_filelist_to_buildtree: evaluate all variables #12043

Merged
merged 1 commit into from
May 2, 2017
Merged

[cmake] copy_files_from_filelist_to_buildtree: evaluate all variables #12043

merged 1 commit into from
May 2, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented May 1, 2017

Description

This will evaluate variables used in cmake/installdata/*/*.txt files.

Motivation and Context

This allows to add project/BuildDependencies/${ARCH}/bin/*.dll . and ${ARCH} will get evaluated.

How Has This Been Tested?

Tested with the above given example.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added CMake Type: Feature non-breaking change which adds functionality v18 Leia labels May 1, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone May 1, 2017
@Rechi Rechi requested review from hudokkow and wsnipex May 1, 2017 14:59
@Rechi
Copy link
Member Author

Rechi commented May 2, 2017

jenkins build this please

@Rechi
Copy link
Member Author

Rechi commented May 2, 2017

@wsnipex any objection?
hudokkow told me I should also ping you

wsnipex
wsnipex approved these changes May 2, 2017
View reviewed changes
Copy link
Member

@wsnipex wsnipex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me

@Rechi Rechi merged commit b92b75a into xbmc:master May 2, 2017
@Rechi Rechi deleted the cmakeCopyBuildtree branch May 2, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudokkow hudokkow hudokkow approved these changes

@wsnipex wsnipex wsnipex approved these changes

Assignees
No one assigned
Labels
CMake Type: Feature non-breaking change which adds functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rechi @hudokkow @wsnipex