Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildsteps][windows] download-msys2: disable build32 if build64 specified #12095

Merged
merged 1 commit into from
May 15, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented May 15, 2017

Description

No need to install 32 bit dependencies / packages, if building for 64 bit.

Motivation and Context

speed up build time

How Has This Been Tested?

compiled on windows 32 and 64 bit

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

…ified

split long lines into multiple lines, otherwise a goto label may not be found
@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality v18 Leia Platform: Windows labels May 15, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone May 15, 2017
@Rechi
Copy link
Member Author

Rechi commented May 15, 2017

also tested with jenkins for 32 and 64 bit and it succeeded

@Rechi Rechi merged commit 2976a98 into xbmc:master May 15, 2017
@Rechi Rechi deleted the buildstepsWindows branch May 15, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Windows Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant