Fix for a hangup when viewing a PVR recording and pressing next/previ…

[hugegreenbug]

…ous (#17476)

This fix skips channel up/down events for saved recordings to prevent the hang

Description

Fixes a hang when pressing previous or next while viewing a saved recording

http://trac.kodi.tv/ticket/17476

Motivation and Context

How Has This Been Tested?

Compiled on MacOS. Binary addons are not showing up with the latest master, so I haven't been able to test fully.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [X ] My code follows the Code guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• [X ] I have read the CONTRIBUTING document
• I have added tests to cover my change
• All new and existing tests passed

[ksooo]

I bet that you have not tested this, because it will not even compile. In master, there is no symbol g_PVRManager anymore. Come on, you can do better.

Hint: CServiceBroker::GetPVRManager()

[hugegreenbug]

Yeah, I said I didn't test it yet. I'm working on it.

[ksooo]

Yeah, I said I didn't test it yet. I'm working on it.

It is no good practice to submit a PR that has not been compiled/tested locally on at least one platform before. Submitting a PR draws attention of other people and I hate (!) spending my time reviewing a PR and detecting syntax errors, you know. This is the job of compilers before a human beeing gets bothered with the code. ;-)

[hugegreenbug]

OK, sorry.

…

On Jun 1, 2017 5:00 AM, "Kai Sommerfeld" ***@***.***> wrote: Yeah, I said I didn't test it yet. I'm working on it. It is no good practice to submit a PR that has not been compiled/tested locally on at least one platform before. Submitting a PR draws attention of other people and I hate (!) spending my time reviewing a PR and detecting syntax errors you know. This is the job of compilers before a human beeing gets bothered with the code. ;-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12210 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABlFSe5Ka6ky4i27r6h6RLTuZ6smyFp-ks5r_pm1gaJpZM4NsxW5> .

[ksooo]

Nono, let's keep it open now that things are sorted out. My goal was to engage you to do better next time. ;-)

[pollito05]

yes

[hugegreenbug]

@ksooo I have changed g_PVRManager to CServiceBroker::GetPVRManager() and compiled it locally. I am unable to test fully since the binary addons are not showing up in my build. I was told it may be due to recent changes.

[ksooo]

@hugegreenbug can you please squash changes into a single commit.

[hugegreenbug]

@ksooo Ok, I committed it as a single commit.

[ksooo]

Thank you

jenkins build and merge