Game OSD #12367
Merged
Game OSD #12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
reviewed
Jun 26, 2017
| @@ -473,3 +474,11 @@ bool CGUIWindowFullScreen::HasVisibleControls() | |||
| { | |||
| return m_controlStats->nCountVisible > 0; | |||
| } | |||
|
|
|||
| int CGUIWindowFullScreen::GetOSDWindowID() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Jun 26, 2017
garbear
force-pushed
the
game-osd
branch
5 times, most recently
from
af307c0
to
1fc1932
Compare
|
I rebased on master and was able to separate out all the joystick changes into #12366. This PR is now game OSD only, so it should be easier to review. |
|
jenkins build this please |
|
Failures are all related to #12426 |
|
@garbear this bring a problem on games, there reset the left and right the game and open the kodi gui slowly, see my video on slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Game OSD and greatly improves input handling. The required changes have been split into three PRs so that it can be merged in stages. The first two PRs are:
Motivation and Context
Needed a way to access the future Video Filters dialog (for GSoC) from within the game.
How Has This Been Tested?
Still in the early stages of testing.
Screenshots (if appropriate):
Main menu:
Video settings:
Input settings:
Types of change