Fix crash on startup #12426
Merged
Fix crash on startup #12426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash on startup introduced in commit 26349e1, "Move CInputManager into service manager" from PR 12366.
|
jenkins build this please |
|
Confirmed working in slack |
This was referenced Jul 5, 2017
|
Reverted and fixed properly in #12432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash on startup introduced in commit 26349e1, "Move CInputManager into service manager" from #12366.
Specifically,
CAppParamParserreferencesCInputManagerwhich is owned byCServiceManager, which hasn't been created or initialized yet.To fix this, we create
CServiceManagerbefore the input manager is accessed. This causes the IR remote commands to be performed on an uninitialized CInputManager, which is perfectly acceptable as these parameters are meant to be set before initialization.