game: fix order of init/deinit in ServiceManager

[FernetMenta]

see title

@garbear /cc

[FernetMenta]

jenkins build this please

[garbear]

What ever happened to the LIFO idea? This is going to keep biting us without a LIFO.

[garbear]

CInputManager is accessed from main() on linux. It doesn't need to be initialized, it just has to be created. CAppParamParser sets some properties that are read upon its initialization.

[FernetMenta]

this pr makes it lifo

in:

m_announcementManager
m_gameServices.reset(new GAME::CGameServices);
m_peripherals.reset(new PERIPHERALS::CPeripherals);
m_inputManager.reset(new CInputManager);

out:
m_inputManager.reset();
m_peripherals.reset();
m_gameServices.reset();
m_announcementManager.reset();

prior to this it was no lifo because announcementManager is supposed to be first. your ctor init made game first.

[FernetMenta]

CInputManager is accessed from main() on linux

in this case it shouldn't be owned by ServiceManager

[FernetMenta]

btw: kodi-test crashed because peripherial depends on announcementManager

[garbear]

in this case it shouldn't be owned by ServiceManager

In the case where it is owned by ServiceManager, main() shouldn't call into CInputManager.

The change here is correct. I can refactor the CAppParamParser issue later today.

[garbear]

BTW #12426 can be reverted once we take care of this mess.

[FernetMenta]

@garbear do you want to take over this pr?

[garbear]

No :) But I think I see how things should be so I'll tackle this issue and open a new PR.

[FernetMenta]

that's what I meant. if you open a new PR, I can close this one, right?

[garbear]

Superseded by #12432