Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] samba-gplv3: fix large offset #12477

Merged
merged 2 commits into from
Jul 13, 2017
Merged

[depends] samba-gplv3: fix large offset #12477

merged 2 commits into from
Jul 13, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Jul 12, 2017

Description

Android NDK doesn't support LARGE_OFFSET and therefore off_t has only a width of 32 bit. This Replaces every occurrence of off_t with off64_t (64 bit with) for android.

Motivation and Context

Kodi on android shows wrong filesize for samba shares if size is over 2^32 bytes because of the limited off_t width.
I missed some off_t at the samba bump.

How Has This Been Tested?

confirmed working by @da-anda

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Platform: Android Component: Depends Type: Fix non-breaking change which fixes an issue v18 Leia labels Jul 12, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Jul 12, 2017
@Rechi Rechi requested review from koying and wsnipex July 12, 2017 13:29
@da-anda
Copy link
Member

da-anda commented Jul 12, 2017

as mentioned, I can confirm this fixes the issues I noticed. Not only the file sizes had been displayed wrong, but also playback of files > 2^32 bytes was not possible, because anything beyond that point could not be read by ffmpeg/videoplayer, and thus playback got aborted.

@Rechi
Copy link
Member Author

Rechi commented Jul 13, 2017

osx failure not related as this only touches android

@Rechi Rechi merged commit 2a62f3e into xbmc:master Jul 13, 2017
@Rechi Rechi deleted the sambaOff64 branch July 13, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants