RetroPlayer: Fix black screen when playing games #12507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of unique_ptr after VideoBuffers switched to shared_ptr caused an exception to be thrown on every frame.
The RenderManager (or somewhere in the rendering pipeline) no longer checks for DVD_NOPTS_VALUE, so passing a pts with this value caused RenderManager to think the frame is far in the future. By setting it to zero, RenderManager should never add any extra delays waiting for pts to arrive.
garbear
added
Type: Fix
|
jenkins build this please |
|
jenkins build and merge |
|
Windows failed due to an IO error. |
|
After this was added whenever I launch games via IARL I only get a blank/black screen. Works fine in prior releases. |
|
Fixed by #12546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two fixes for two separate bugs causing a black screen during gameplay. It also contains some minor improvements that shouldn't affect playback.