Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetroPlayer: Fix black screen on playback #12546

Merged
merged 3 commits into from
Jul 24, 2017

Conversation

garbear
Copy link
Member

@garbear garbear commented Jul 21, 2017

If the title of this PR looks familiar, it's because RetroPlayer broke yet again with the last VP update. This fixes the blank screen that shows when playing games.

How Has This Been Tested?

Games play with video now.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@garbear garbear added Type: Fix non-breaking change which fixes an issue Component: Games v18 Leia labels Jul 22, 2017
@garbear garbear added this to the L 18.0-alpha1 milestone Jul 22, 2017
@thejims
Copy link

thejims commented Jul 23, 2017

I think this was pulled in on the latest build.. if so still getting black screen.
pastebin: http://sprunge.us/FEFa

@garbear
Copy link
Member Author

garbear commented Jul 23, 2017

@thejims This problem seems to be RPi specific. I've pushed a fix. I haven't tested on an RPi, but I have evidence that it fixes the problem. @MilhouseVH can you make sure the updated PR is included in your builds? thanks!

@MilhouseVH
Copy link
Contributor

@MilhouseVH can you make sure the updated PR is included in your builds?

Will do.

@thejims
Copy link

thejims commented Jul 24, 2017

Working great on RPi3 with the latest build! Ty!

@garbear
Copy link
Member Author

garbear commented Jul 24, 2017

jenkins build and merge

@MartijnKaijser MartijnKaijser merged commit 4e86ad6 into xbmc:master Jul 24, 2017
@garbear garbear deleted the fix-retroplayer branch July 24, 2017 07:03
@garbear garbear mentioned this pull request Aug 13, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Games Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants