Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetroPlayer: Fix black screen on playback #12546

Merged
merged 3 commits into from Jul 24, 2017

Conversation

@garbear
Copy link
Member

commented Jul 21, 2017

If the title of this PR looks familiar, it's because RetroPlayer broke yet again with the last VP update. This fixes the blank screen that shows when playing games.

How Has This Been Tested?

Games play with video now.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@thejims

This comment has been minimized.

Copy link

commented Jul 23, 2017

I think this was pulled in on the latest build.. if so still getting black screen.
pastebin: http://sprunge.us/FEFa

@garbear

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2017

@thejims This problem seems to be RPi specific. I've pushed a fix. I haven't tested on an RPi, but I have evidence that it fixes the problem. @MilhouseVH can you make sure the updated PR is included in your builds? thanks!

@garbear garbear force-pushed the garbear:fix-retroplayer branch from 4aee70c to 5e05c68 Jul 23, 2017

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2017

@MilhouseVH can you make sure the updated PR is included in your builds?

Will do.

@thejims

This comment has been minimized.

Copy link

commented Jul 24, 2017

Working great on RPi3 with the latest build! Ty!

@garbear

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2017

jenkins build and merge

@MartijnKaijser MartijnKaijser merged commit 4e86ad6 into xbmc:master Jul 24, 2017

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@garbear garbear deleted the garbear:fix-retroplayer branch Jul 24, 2017

@garbear garbear referenced this pull request Aug 13, 2017
1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.