[xbmc] Addon settings fixes #12536
Merged
[xbmc] Addon settings fixes #12536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he element name instead of the id Fix a conversion issue where settings without category was skipped over.
Paxxi
added
Type: Fix
garbear
reviewed
Jul 20, 2017
| settingId += setting->ValueStr(); | ||
| auto id = setting->ToElement()->Attribute("id"); | ||
| if (id) | ||
| settingId += id; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
peak3d
reviewed
Jul 20, 2017
| // build a vector of settings from the same category | ||
| std::vector<std::shared_ptr<const CSetting>> categorySettings; | ||
| std::set<std::string> settingIds; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
peak3d
requested changes
Jul 20, 2017
|
@Paxxi anything left or need updating? |
|
Good to go @martijn. Was waiting on me looking into peaks comment but no changes are warranted there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a parsing issue for new setting format where settingId would be the element name instead of the id
Fix a conversion issue where settings without category was skipped over.
This should solve log spam of creating settings on the fly for valid addons and properly save/load addons after converted to the new setting format.
@peak3d for testing.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: