Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix and refactor PVR internal 'playing' states after removal of… #12607

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Aug 1, 2017

… VideoPlayer's 'other stream hack'."

Hopefully the last fallout from #12550. Fixes Live TV OSD for playing "dynpath" channels and other glitches.

This has been runtime tested on macOS, latest Kodi master.

@FernetMenta as discussed on Slack...

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v18 Leia labels Aug 1, 2017
@ksooo ksooo added this to the L 18.0-alpha1 milestone Aug 1, 2017
@ksooo ksooo requested a review from FernetMenta August 1, 2017 21:11
* @brief Set the channel that is currently playing.
* @param channel The channel that is currently playing.
*/
void SetPlayingChannel(const CPVRChannelPtr channel);

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@@ -3501,6 +3501,8 @@ void CApplication::OnPlayBackEnded()
CDarwinUtils::EnableOSScreenSaver(true);
#endif

CServiceBroker::GetPVRManager().OnPlaybackEnded(m_itemCurrentFile);

This comment was marked as spam.

This comment was marked as spam.

@ksooo ksooo merged commit 66fb905 into xbmc:master Aug 2, 2017
@ksooo ksooo deleted the pvr-fix-dynpath-item-playback branch August 2, 2017 07:25
@@ -3568,6 +3572,8 @@ void CApplication::OnPlayBackStopped()
CDarwinUtils::EnableOSScreenSaver(true);
#endif

CServiceBroker::GetPVRManager().OnPlaybackStopped(m_itemCurrentFile);

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants