SPDIF: Make it possible to use 352 khz and 384 khz #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specs of the Marantz say that 384kHz/32bit is only supported via USB though. Digital inputs (coax, optical) are limited to 192kHz/24bit which is the max for any S/PDIF transmitter I have seen so far. |
|
Better: USB device, that tells it has a SPDIF out and accepts 384 / 32 bit ? Kodi handles it the way ALSA enumerates it and this is SPDIF. |
vpeter4
reviewed
Sep 9, 2017
| @@ -16383,8 +16383,20 @@ msgctxt "#34128" | |||
| msgid "192.0" | |||
| msgstr "" | |||
|
|
|||
| #. SPDIF max sampling rate | |||
| #: system/settings/settings.xml | |||
| msgctxt "#34130" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@vpeter4: thx - I fixed it up. |
|
Working as it should. Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not believe it first, but there are now SPDIF devices out there that accept 384 khz / 32 bit input. See for example the following device: http://www.ca.marantz.com/ca/Products/Pages/ProductDetails.aspx?CatId=HiFiComponents&SubCatId=0&ProductId=HDAMP1
A user on LibreELEC forum verified with ALSA's speaker-test that it works correctly. In order to support this usecase a minimal change to kodi (only Settings and Language) needs to happen.
Note: ALSA sink currently does not support 352 khz, but pulseaudio does. 384 khz both support.
LE Forum thread: https://forum.libreelec.tv/thread/9823-audio-output-device-sampling-rate/?pageNo=1